Skip to content

[TASK] Improve BE Tablelist ViewHelper page #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
linawolf merged 2 commits into from
Mar 16, 2025
Merged

[TASK] Improve BE Tablelist ViewHelper page #105

linawolf merged 2 commits into from
Mar 16, 2025

Conversation

@linawolf
Copy link
Member

@linawolf linawolf commented Mar 16, 2025

Releases: main, 13.4

froemken
froemken approved these changes Mar 16, 2025
View reviewed changes
Copy link
Contributor

@froemken froemken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All describing texts for properties starting with lower case (OK, as they were imported 1:1 from VH) and we have an indent of 8 spaces, wow. 4 would be OK or maybe 6 to line them up with the VH name

@froemken
Copy link
Contributor

froemken commented Mar 16, 2025

Example. That's what I mean with line up with VH name

<f:be.tableList
      tableName="tt_content"
      fieldList="{0: 'header', 1: 'CType'}"
      storagePid="1"
      levels="2"
      enableControlPanels="1"
/>

@linawolf
Copy link
Member Author

linawolf commented Mar 16, 2025

All describing texts for properties starting with lower case (OK, as they were imported 1:1 from VH)
That would have to be fixed in the core

@linawolf linawolf merged commit aedfdfa into main Mar 16, 2025
2 checks passed
@linawolf linawolf deleted the task/betablelist branch March 16, 2025 14:32
@github-actions github-actions bot mentioned this pull request Mar 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@froemken froemken froemken approved these changes

Assignees

No one assigned

Labels

backport 13.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@linawolf @froemken